Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express middleware global logger: should properly write log entries failed #619

Closed
flaky-bot bot opened this issue Apr 18, 2022 · 3 comments
Closed
Assignees
Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Apr 18, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 75d7811
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly equal:

0 !== 1

  + expected - actual

  -0
  +1

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

0 !== 1

at Context.<anonymous> (build/system-test/test-middleware-express.js:43:20)
    -> /workspace/system-test/test-middleware-express.ts:50:14</pre></details>
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 18, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Apr 18, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 20, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (75d7811), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Apr 20, 2022
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 25, 2022
@losalex losalex assigned losalex and unassigned daniel-sanche May 3, 2022
@losalex
Copy link
Contributor

losalex commented May 3, 2022

There is an issue with proto compilation which breaks the build and fixed in 2112. Waiting for fix to propagate, so tests will be back to normal

@losalex losalex added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 3, 2022
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label May 3, 2022
@losalex
Copy link
Contributor

losalex commented May 5, 2022

Fix checked in and latest tests are normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants