Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: COUNT Queries #1774

Merged
merged 33 commits into from Oct 3, 2022
Merged

feat: COUNT Queries #1774

merged 33 commits into from Oct 3, 2022

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 15, 2022 •
edited by dconeybe

Add support for "count" queries; that is, a query that gets the number of documents in the result set without actually downloading the documents.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 15, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Sep 16, 2022
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 16, 2022
dconeybe
dconeybe requested changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the non-test code so far. I'm not done my review, but wanted to send my feedback now because I probably won't get back to it until later today.

types/firestore.d.ts Outdated Show resolved Hide resolved
types/firestore.d.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dconeybe
dconeybe previously requested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments, Tom. I just have one minor follow-up comment. I'm going to pass off this review to @ehsannas or @wu-hui to also review the test code.

dev/src/reference.ts Outdated Show resolved Hide resolved
@ehsannas
Copy link
Contributor

ehsannas commented Sep 21, 2022 •
edited

Can you fix the CI failures? (Property 'getCount' does not exist on type 'AggregateQuerySnapshot<{ count: AggregateField<number>; }>')

ehsannas
ehsannas reviewed Sep 21, 2022
View reviewed changes
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/src/reference.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Sep 22, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Sep 22, 2022
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2022
ehsannas
ehsannas approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added the "do not merge" label. Since the PR exposes the API publicly we should wait until allowed to merge the PR.

@dconeybe dconeybe changed the title feat: Tomandersen/count feat: COUNT Queries Sep 29, 2022
@dconeybe dconeybe changed the base branch from count to main September 30, 2022 17:31
@ehsannas ehsannas removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 3, 2022
@tom-andersen tom-andersen added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 3, 2022
@tom-andersen tom-andersen dismissed dconeybe’s stale review October 3, 2022 19:41

Denver is away, and won't be able to approve.

@tom-andersen tom-andersen merged commit bcaecb4 into main Oct 3, 2022
@tom-andersen tom-andersen deleted the tomandersen/count branch October 3, 2022 19:41
@release-please release-please bot mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees

@tom-andersen tom-andersen

@dconeybe dconeybe

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tom-andersen @ehsannas @dconeybe @yoshi-kokoro