Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove hack in update.sh, and replace with existing pattern for protobuf dependencies. #1769

Merged
merged 1 commit into from Sep 8, 2022

Conversation

tom-andersen
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 8, 2022
@tom-andersen tom-andersen force-pushed the tomandersen/fixUpdateProtoScript branch from b66d3d7 to d4866cf Compare September 8, 2022 14:15
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 8, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@tom-andersen tom-andersen marked this pull request as ready for review September 8, 2022 14:18
@tom-andersen tom-andersen requested review from a team as code owners September 8, 2022 14:18
@tom-andersen tom-andersen changed the title fix: Remove hack, and replace with existing pattern for protobuf dependencies. fix: Remove hack in update.sh, and replace with existing pattern for protobuf dependencies. Sep 8, 2022
@tom-andersen tom-andersen merged commit 6ba6751 into main Sep 8, 2022
@tom-andersen tom-andersen deleted the tomandersen/fixUpdateProtoScript branch September 8, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants