Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update BulkWriterError documentation #1518

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

thebrianchen
Copy link

I realized that our current documentation does not have any property definitions for BulkWriterError.

@thebrianchen thebrianchen requested review from a team as code owners May 26, 2021 18:20
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label May 26, 2021
* @property {string} message The error message of the error.
* @property {DocumentReference} documentRef The document reference the operation was
* performed on.
* @property {'create' | 'set' | 'update' | 'delete'} operationType The type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you verified that this looks good in the generated docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@thebrianchen thebrianchen merged commit 0515d1f into master May 26, 2021
@thebrianchen thebrianchen deleted the bc/bulk-docs2 branch May 26, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants