fix: remove floating point rounding error in Timestamp.fromMillis() #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 98.21% 98.20% -0.02%
==========================================
Files 32 32
Lines 19567 19569 +2
Branches 1373 1285 -88
==========================================
Hits 19217 19217
- Misses 346 348 +2
Partials 4 4
Continue to review full report at Codecov.
|
dev/src/timestamp.ts
Outdated
| @@ -107,7 +107,9 @@ export class Timestamp implements firestore.Timestamp { | |||
| */ | |||
| static fromMillis(milliseconds: number): Timestamp { | |||
| const seconds = Math.floor(milliseconds / 1000); | |||
| const nanos = (milliseconds - seconds * 1000) * MS_TO_NANOS; | |||
| const nanos = Math.round( | |||
There was a problem hiding this comment.
I think you need to round down here so that nanos is always less than "one second in nanos".
schmidt-sebastian
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463.
By multiplying
MS_TO_NANOSseparately, we avoid the floating point precision rounding errors.