fix: update queryAsStream_ to set options with Query type #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
steffnay
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
There was a problem hiding this comment.
This generally looks ok due to the extend below, but it doesn't really match the pattern elsewhere in the library. I'd love to see 2 things here:
- a comment above line 2011 that explains why this is different
- a test that validates the fix you're making so it doesn't regress
steffnay
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
steffnay
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
JustinBeckwith
approved these changes
Oct 12, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
馃 I have created a release \*beep\* \*boop\* --- ### [5.9.1](https://www.github.com/googleapis/nodejs-bigquery/compare/v5.9.0...v5.9.1) (2021-10-12) ### Bug Fixes * update queryAsStream_ to set options with Query type ([#999](https://www.github.com/googleapis/nodejs-bigquery/issues/999)) ([e7eab0b](https://www.github.com/googleapis/nodejs-bigquery/commit/e7eab0b25c18c6bbb9fa0f92f180ba70632675aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures query options that are provided within the single
Querytype parameter are properly set, which will allow thewrapIntegersoption to work with streaming.Fixes #947 馃