feat: add table.createInsertStream for native streaming inserts #997
+971
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
steffnay
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
tswast
reviewed
Oct 13, 2021
tswast
reviewed
Oct 13, 2021
tswast
reviewed
Oct 13, 2021
| maxOutstandingBytes: 1 * 1024 * 1024, | ||
|
|
||
| // The maximum time we'll wait to send batched rows, in milliseconds. | ||
| maxDelayMillis: 10000, |
There was a problem hiding this comment.
Just based off similar batching of messages in nodejs-pubsub, do you have an idea of a timeframe that is better aligned for BigQuery inserts?
There was a problem hiding this comment.
Not really. I think it has more to do with the customer's requirements than BigQuery limitations. Since it's configurable, aligning the default with pub/sub makes sense to me.
feywind
reviewed
Oct 13, 2021
…into createInsertStream
…into createInsertStream
steffnay
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
approved these changes
Jan 11, 2022
| const opts = typeof options === 'object' ? options : {}; | ||
|
|
||
| if (opts.insertRowsOptions) { | ||
| this.insertRowsOptions = opts.insertRowsOptions; |
There was a problem hiding this comment.
Ah geez, I never actually gave this link to you... Here's one method:
| }; | ||
| }), | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| row: rows[(insertError as any).index], |
tswast
approved these changes
Jan 12, 2022
| maxOutstandingBytes: 1 * 1024 * 1024, | ||
|
|
||
| // The maximum time we'll wait to send batched rows, in milliseconds. | ||
| maxDelayMillis: 10000, |
There was a problem hiding this comment.
Not really. I think it has more to do with the customer's requirements than BigQuery limitations. Since it's configurable, aligning the default with pub/sub makes sense to me.
steffnay
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the ability to use a native Duplex stream for inserting rows into BigQuery via the
/insertAllendpoint and reading the API response. Implements batching of rows viaRowBatchandRowQueueclasses.Adds:
Table.createInsertStream()
RowQueue
RowBatch
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #506 🦕