Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set projectId in jobs emitted by load streams #1346

Merged
merged 2 commits into from Mar 27, 2024

Conversation

1kilobit
Copy link
Contributor

@1kilobit 1kilobit commented Mar 27, 2024

This explicitly sets the project ID in jobs returned by loading operations that are stream-based (e.g. Table.load(filePath) or Table.createWriteStream()), which fixes support for project IDs specified at the dataset level.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1345 馃

Copy link

google-cla bot commented Mar 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Mar 27, 2024
@1kilobit 1kilobit marked this pull request as ready for review March 27, 2024 01:39
@1kilobit 1kilobit requested review from a team as code owners March 27, 2024 01:39
@1kilobit 1kilobit requested a review from tswast March 27, 2024 01:39
@tswast tswast requested review from alvarowolfx and removed request for tswast March 27, 2024 14:52
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @onekilobit-supersocial. Changes looks good to me. I'll wait for CI test to run and merge it.

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@alvarowolfx alvarowolfx added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@alvarowolfx alvarowolfx added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@alvarowolfx alvarowolfx merged commit bd8254c into googleapis:main Mar 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading via write streams into Tables from Datasets with manually-specified project IDs returns invalid job
3 participants