Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cross-project support #1079

Merged
merged 5 commits into from Feb 10, 2022
Merged

feat: add cross-project support #1079

merged 5 commits into from Feb 10, 2022

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Feb 6, 2022 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1030 #527 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Feb 6, 2022
@steffnay steffnay marked this pull request as ready for review February 6, 2022 20:16
@steffnay steffnay requested a review from a team February 6, 2022 20:16
@steffnay steffnay requested a review from a team as a code owner February 6, 2022 20:16
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2022
@satrox28
Copy link

satrox28 commented Feb 8, 2022

Hi @shollyman,

Can you able to check and approve it. We are eagerly looking for this feature from past few months.

shollyman
shollyman approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need more disambiguation for expressing fully qualified references for non-dataset resources like jobs?

feywind
feywind approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satrox28
Copy link

Can it be merged, any pending?

@steffnay steffnay merged commit f6a7456 into googleapis:main Feb 10, 2022
@release-please release-please bot mentioned this pull request Feb 10, 2022
Merged
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
@atrbgithub atrbgithub mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross Project Support
4 participants
@steffnay @satrox28 @shollyman @feywind