Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor to extract options from query #1045

Merged
merged 7 commits into from Dec 13, 2021
Merged

fix: refactor to extract options from query #1045

merged 7 commits into from Dec 13, 2021

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Nov 22, 2021 •
edited

Updates queryAsStream_ to pass only necessary properties as options rather than entire query object.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1043 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Nov 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2021
@steffnay steffnay marked this pull request as ready for review November 22, 2021 20:11
@steffnay steffnay requested a review from a team November 22, 2021 20:11
@steffnay steffnay requested a review from a team as a code owner November 22, 2021 20:11
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 22, 2021
@mbyrne00 mbyrne00 mentioned this pull request Dec 6, 2021
Closed
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2021
@steffnay steffnay merged commit 4afed77 into googleapis:main Dec 13, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 13, 2021
@release-please
chore: release 5.9.3 (#1052)
a4625c3 
🤖 I have created a release \*beep\* \*boop\*
---
### [5.9.3](https://www.github.com/googleapis/nodejs-bigquery/compare/v5.9.2...v5.9.3) (2021-12-13)


### Bug Fixes

* refactor to extract options from query ([#1045](https://www.github.com/googleapis/nodejs-bigquery/issues/1045)) ([4afed77](https://www.github.com/googleapis/nodejs-bigquery/commit/4afed77c0e21568546bb6363936b10d15c9c93db))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bigquery createQueryStream broken in 5.9.1+ for large query after set options update
2 participants
@steffnay @JustinBeckwith