Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add jobs.delete #1023

Merged
merged 25 commits into from Jan 10, 2022
Merged

feat: Add jobs.delete #1023

merged 25 commits into from Jan 10, 2022

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Oct 8, 2021 •
edited

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1010 🦕

@steffnay steffnay requested a review from a team October 8, 2021 21:28
@steffnay steffnay requested a review from a team as a code owner October 8, 2021 21:28
@steffnay steffnay requested a review from loferris October 8, 2021 21:28
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Oct 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@steffnay steffnay added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Oct 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay assigned steffnay and unassigned stephenplusplus Oct 8, 2021
@steffnay steffnay changed the title feat: Add jobs.delete feat: Add jobs.delete and update to latest discovery types Oct 10, 2021
JustinBeckwith
JustinBeckwith previously requested changes Oct 11, 2021
View reviewed changes
src/job.ts Outdated Show resolved Hide resolved
src/job.ts Outdated Show resolved Hide resolved
JustinBeckwith
JustinBeckwith reviewed Nov 3, 2021
View reviewed changes
src/job.ts Outdated Show resolved Hide resolved
src/job.ts Outdated Show resolved Hide resolved
@steffnay
Copy link
Contributor Author

steffnay commented Nov 15, 2021 •
edited

@JustinBeckwith I realized I needed to refactor, so the type issues are no longer a thing.

@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 3, 2022
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@steffnay steffnay merged commit 12f7771 into googleapis:main Jan 10, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 10, 2022
@release-please
chore: release 5.10.0 (#1059)
5d5facd 
🤖 I have created a release \*beep\* \*boop\*
---
## [5.10.0](https://www.github.com/googleapis/nodejs-bigquery/compare/v5.9.3...v5.10.0) (2022-01-10)


### Features

* Add jobs.delete and update to latest discovery types ([#1023](https://www.github.com/googleapis/nodejs-bigquery/issues/1023)) ([12f7771](https://www.github.com/googleapis/nodejs-bigquery/commit/12f77710accfca8c512d021a1c75a732c6c666f7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@steffnay steffnay changed the title feat: Add jobs.delete and update to latest discovery types feat: Add jobs.delete Jan 18, 2022
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel left review comments

@bcoe bcoe bcoe approved these changes

@loferris loferris Awaiting requested review from loferris

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees

@steffnay steffnay

Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery - support jobs.delete
5 participants
@steffnay @fhinkel @bcoe @JustinBeckwith @stephenplusplus