fix: update Grpc Write implementation to allow specifying expected md5 #1815
+157
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
BenWhitehead
force-pushed
the
grpc/write/md5-match
branch
from
7fabc19
to
2eb8d67
Compare
frankyn
approved these changes
Dec 16, 2022
|
Thanks for the succinct PR! |
Remove Hasher.Constant. StartResumableWriteRequest has been updated to allow specifying `object_checksums` when creating the session. Add several new positive and negative integration test for md5 verification
BenWhitehead
force-pushed
the
grpc/write/md5-match
branch
from
2eb8d67
to
4799d34
Compare
BenWhitehead
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Hasher.Constant. StartResumableWriteRequest has been updated to allow specifying
object_checksumswhen creating the session.Add several new positive and negative integration test for md5 verification