feat: support readTime in Datastore query splitter. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
kolea2
requested changes
Jun 15, 2022
datastore-v1-proto-client/src/main/java/com/google/datastore/v1/client/QuerySplitterImpl.java
Show resolved
Hide resolved
...-proto-client/src/main/java/com/google/datastore/v1/client/testing/MockDatastoreFactory.java
Outdated
Show resolved
Hide resolved
...-proto-client/src/main/java/com/google/datastore/v1/client/testing/MockDatastoreFactory.java
Outdated
Show resolved
Hide resolved
kolea2
requested changes
Jun 15, 2022
There was a problem hiding this comment.
also, we can fix clirr by adding the method to a clirr-ignored-differences.xml like https://github.com/googleapis/java-datastore/blob/main/google-cloud-datastore/clirr-ignored-differences.xml (since we added a default method, this is okay)
Done |
kolea2
approved these changes
Jun 21, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2022-06-22) ### Features * support readTime in Datastore query splitter. ([#763](#763)) ([61758e0](61758e0)) ### Documentation * **sample:** clean up README for native image sample ([#771](#771)) ([7358aa3](7358aa3)) ### Dependencies * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#773](#773)) ([cab7e54](cab7e54)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#774](#774)) ([496c1bc](496c1bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.