Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: Add sample snippets for IN, NOT_EQUALS, and NOT_IN #749

Merged
merged 5 commits into from
Jun 14, 2022

Conversation

jlara310
Copy link
Contributor

@jlara310 jlara310 commented May 25, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #738 ☕️

Depends on #688
If you write sample code, please follow the samples format.

@snippet-bot
Copy link

snippet-bot bot commented May 25, 2022

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels May 25, 2022
@jlara310 jlara310 changed the title Add sample snippets for IN, NOT_EQUALS, and NOT_IN test: Add sample snippets for IN, NOT_EQUALS, and NOT_IN May 25, 2022
@jlara310
Copy link
Contributor Author

Now that #688 is merged, this is also ready for review/merge.

@jlara310
Copy link
Contributor Author

The project used for testing requires the index below for one of the snippets:

- kind: Task
  properties:
  - name: tag
  - name: tag

Can someone help me add this index to the testing project?

@kolea2 kolea2 changed the title test: Add sample snippets for IN, NOT_EQUALS, and NOT_IN samples: Add sample snippets for IN, NOT_EQUALS, and NOT_IN Jun 10, 2022
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question. Thanks!

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2022
@jlara310 jlara310 requested a review from kolea2 June 13, 2022 18:05
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 13, 2022
@jlara310
Copy link
Contributor Author

Looks like ConceptsTest.java runs against the Datastore emulator. The new query operators will not be supported by the emulator any time soon. Not sure how to proceed. Is there a way to run the new tests against a real backend?

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2022
@jlara310
Copy link
Contributor Author

Can someone re-trigger the workflows for me again?

@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2022
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2022
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2022
@kolea2 kolea2 merged commit 3efd61c into googleapis:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation snippets for IN/NOT_IN/NOT_EQUAL operators
4 participants