Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OAuthCredentialsResponse.java #326

Closed
wants to merge 1 commit into from
Closed

Update OAuthCredentialsResponse.java #326

wants to merge 1 commit into from

Conversation

cmunden
Copy link
Contributor

@cmunden cmunden commented Jul 10, 2019 •
edited

Extending HashMap allows any ancillary response values provided by the service endpoint to be retrieved from the credential response.

Fixes #325 (it's a good idea to open an issue first for discussion)

  • Tests pass
  • Appropriate docs were updated (if necessary)

@cmunden
Update OAuthCredentialsResponse.java
46dfa89 
Extending HashMap allows any ancillary response values provided by the service endpoint to be retrieved from the credential response.
@cmunden cmunden requested a review from a team as a code owner July 10, 2019 15:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@cmunden cmunden closed this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuthCredentialsResponse does not support ancillary response attributes
2 participants
@cmunden @googlebot