Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuthCredentialsResponse does not support ancillary response attributes #325

Open
cmunden opened this issue Jul 10, 2019 · 0 comments
Open
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@cmunden
Copy link
Contributor

cmunden commented Jul 10, 2019

Thanks for stopping by to let us know something could be better!

Please be sure to include as much information as possible:

Environment details (provided even though this is more of a feature request)

  • OS: Windows
  • Java version: 8
  • google-oauth-java-client version: 1.30.1

Steps to reproduce (provided to explain the feature request)

  1. AbstractOAuthGetToken instantiates an OAuthCredentialsResponse instance to consume the response from the service endpoint. However, OAuthCredentialsResponse has only 3 attributes. Some service endpoints respond with other important attributes outside of those already in OAuthCredentialsResponse.

Suggested Improvement

  1. Make OAuthCredentialsResponse extend HashMap such that any ancillary attributes returned by the service endpoint can be retrieved from the credentials response.

Thanks!

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 11, 2019
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 15, 2019
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants