Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(samples): Update Dual-Region Bucket Creation Sample to Output Additional Metadata #18968

Closed
danielbankhead opened this issue Aug 4, 2022 · 0 comments · Fixed by #18981
Closed

refactor(samples): Update Dual-Region Bucket Creation Sample to Output Additional Metadata #18968

danielbankhead opened this issue Aug 4, 2022 · 0 comments · Fixed by #18981
Assignees
@danielbankhead
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@danielbankhead
Copy link
Member

We want to update the dual-region samples to uniformly include location, locationType, and customPlacementConfig metadata in the output.

This should be a small change to: https://github.com/googleapis/google-cloud-ruby/blob/HEAD/google-cloud-storage/samples/storage_create_bucket_dual_region.rb

Here's an example from Node.js storage: googleapis/nodejs-storage#2016
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Aug 4, 2022
@danielbankhead danielbankhead self-assigned this Aug 4, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 4, 2022
@danielbankhead danielbankhead mentioned this issue Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples(storage): Update Dual-Region Bucket Creation Metadata googleapis/google-cloud-ruby
1 participant
@danielbankhead