[Spanner] class ReadOnly throws error in PHP 8.1 since it became a reserved word

[taka-oyama]

Trying to use google/cloud-spanner/src/V1/TransactionOptions/ReadOnly.php results in error because readonly became a reserved word in PHP 8.1.

Would it be possible to rename this class?

ParseError {#1842
#message: "syntax error, unexpected token "readonly", expecting identifier"
#code: 0
#file: "./vendor/google/cloud-spanner/src/V1/TransactionOptions/ReadOnly.php"
#line: 16

Environment details

• PHP version: 8.1

Steps to reproduce

1. use PHP 8.1 and instantiate class.

Issue was first raised at colopl/laravel-spanner#38
And more detail was revealed in googleapis/gax-php#374

[bshaffer]

We have a fix submitted to protobuf here: protocolbuffers/protobuf#9633

[taka-oyama]

Thank you for the fix.

I noticed protocolbuffers/protobuf#9633 was merged to master some time ago.

Was this a breaking change? Do we have to wait until protobuf 4.0 for this to be released?

[bshaffer]

Thanks @taka-oyama. Yes, unfortunately we are still waiting for Protobuf to cut a release containing those changes. We will update these packages as soon as it happens.

Fortunately, it will not be a breaking change

[taka-oyama]

Hi, thank you for the quick reply.
I was able to confirm that the fix was included in the v3.21.0 (the tag says v21 but I'm guessing that's a typo?) 🎉.

Hopefully the change will be applied here soon.

[taka-oyama]

Status update.

21.0 was officially released. 🚀

https://github.com/protocolbuffers/protobuf/releases/tag/v21.0

[taka-oyama]

We are eagerly waiting for this fix to be included in the release.
Are there any estimates on when this might be fixed?

[bshaffer]

@taka-oyama unfortunately we discovered a bug in the fix we had and we had to revert the changes. We've submitted a secondary fix here.

We will need to wait until the next release before this rolls out. And because the fix requires a new version of protobuf AND a new version of this library, we have to wait for them to release a new version of protobuf before we can fix it here.

It will be at least two more weeks before this happens, but we are working to get this fix out as quickly as we can.

[taka-oyama]

Thank you for the quick response.

It will be at least two more weeks before this happens, but we are working to get this fix out as quickly as we can.

OK. Understood.

[taka-oyama]

Hi, sorry for the constant ping but I noticed the protocolbuffers/protobuf#10041 has been silent for over 2 weeks now.

Will this be addressed any time soon?

[taka-oyama]

Merged and released!

https://github.com/protocolbuffers/protobuf/releases/tag/v21.3

[bshaffer]

This has been fixed in #5377

[taka-oyama]

Hi, thank you for the fix!

[bshaffer]

You're very welcome! See 0.186.0 for the release notes. The individual packages which were affected by this were:

• google/cloud-spanner: v1.51.0
• google/cloud-datastore: v1.16.0
• google/cloud-firestore: v1.25.0