Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: investigate google.golang.org/api issue #7410

Closed
codyoss opened this issue Feb 10, 2023 · 0 comments · Fixed by googleapis/google-api-go-client#1856
Closed

storage: investigate google.golang.org/api issue #7410

codyoss opened this issue Feb 10, 2023 · 0 comments · Fixed by googleapis/google-api-go-client#1856
Assignees
@codyoss
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@codyoss
Copy link
Member

codyoss commented Feb 10, 2023

Bumping causes TestIndefiniteRetries to fail. May be related to googleapis/google-api-go-client#1802
@codyoss codyoss added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 10, 2023
@codyoss codyoss self-assigned this Feb 10, 2023
@codyoss codyoss mentioned this issue Feb 10, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 10, 2023
@codyoss
chore: revert broken google.golang.org/api to working rev (#7408)
124cad4 
Updates: #7410
codyoss added a commit to codyoss/google-api-go-client that referenced this issue Feb 13, 2023
@codyoss
fix(internal/gensuport): don't prematurely close timers.
3c99d4c 
quitAfterTimer should only be closed when function breaks or
returns as it is created outside of the for loop. Tested with
local replacing and fixes failing TestIndefiniteRetries test with
the patch.

Fixes: googleapis/google-cloud-go#7410
@codyoss codyoss mentioned this issue Feb 13, 2023
Merged
codyoss added a commit to googleapis/google-api-go-client that referenced this issue Feb 13, 2023
@codyoss
fix(internal/gensupport): don't prematurely close timers (#1856)
8efd00d 
quitAfterTimer should only be closed when function breaks or
returns as it is created outside of the for loop. Tested with
local replacing and fixes failing TestIndefiniteRetries test with
the patch.

Updates: googleapis/google-cloud-go#7410
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Feb 13, 2023
@codyoss
chore(storage): update google.golang.org/api
40e6d39 
Updates: googleapis#7410
@codyoss codyoss mentioned this issue Feb 13, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 13, 2023
@codyoss
chore(storage): update google.golang.org/api (#7415)
09e04cd 
Updates: #7410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(internal/gensuport): don't prematurely close timers codyoss/google-api-go-client
1 participant
@codyoss