Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorreporting: don't provide logging #736

Closed
rakyll opened this issue Aug 22, 2017 · 2 comments
Closed

errorreporting: don't provide logging #736

rakyll opened this issue Aug 22, 2017 · 2 comments
Assignees
@rakyll
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rakyll
Copy link
Contributor

rakyll commented Aug 22, 2017

As a result of #728, errorreporting package will work specifically against the errors. The package currently logs to Stackdriver Logging if it is configured so, but we should remove this functionality and allow users to depend on the logging package to report the error message instead. By doing so, we are also giving them opportunity to add more context to the log message.

/cc @zombiezen
@rakyll rakyll added the api: clouderrorreporting Issues related to the Error Reporting API. label Aug 22, 2017
@rakyll rakyll self-assigned this Aug 22, 2017
@rakyll rakyll added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Aug 22, 2017
@rakyll
Copy link
Contributor Author

rakyll commented Aug 31, 2017

/cc @jba @broady

Please provide input, I can remove the logger as a part of https://code-review.googlesource.com/c/gocloud/+/16090.

@anthmgoogle anthmgoogle added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 10, 2017
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 8, 2018
@jba
Copy link
Contributor

jba commented Jun 25, 2018

Fixed by 8b73297.

@jba jba closed this as completed Jun 25, 2018
@yoshi-automation yoshi-automation mentioned this issue Oct 24, 2022
Merged
yoshi-automation added a commit that referenced this issue Oct 24, 2022
@yoshi-automation
chore(all): auto-regenerate gapics
77e5c0b 
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#927

Changes:

feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig
  PiperOrigin-RevId: 482665674
  Source-Link: googleapis/googleapis@64926d5

docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile)
  PiperOrigin-RevId: 482618841
  Source-Link: googleapis/googleapis@62443cf

feat(compute): Update Compute Engine API to revision 20221011 (#736)

  Source-Link: googleapis/googleapis@cb8c914

feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013889
  Source-Link: googleapis/googleapis@5f68158

feat(kms): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013711
  Source-Link: googleapis/googleapis@6d38b26
yoshi-automation added a commit that referenced this issue Oct 24, 2022
@yoshi-automation
chore(all): auto-regenerate gapics
c8bcd99 
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#927

Changes:

feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig
  PiperOrigin-RevId: 482665674
  Source-Link: googleapis/googleapis@64926d5

docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile)
  PiperOrigin-RevId: 482618841
  Source-Link: googleapis/googleapis@62443cf

feat(compute): Update Compute Engine API to revision 20221011 (#736)

  Source-Link: googleapis/googleapis@cb8c914

feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013889
  Source-Link: googleapis/googleapis@5f68158

feat(kms): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013711
  Source-Link: googleapis/googleapis@6d38b26
codyoss added a commit that referenced this issue Oct 24, 2022
@yoshi-automation @codyoss
chore(all): auto-regenerate gapics (#6914)
aad4787 
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#927

Changes:

feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig
  PiperOrigin-RevId: 482665674
  Source-Link: googleapis/googleapis@64926d5

docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile)
  PiperOrigin-RevId: 482618841
  Source-Link: googleapis/googleapis@62443cf

feat(compute): Update Compute Engine API to revision 20221011 (#736)

  Source-Link: googleapis/googleapis@cb8c914

feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013889
  Source-Link: googleapis/googleapis@5f68158

feat(kms): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013711
  Source-Link: googleapis/googleapis@6d38b26

Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@release-please release-please bot mentioned this issue Oct 24, 2022
Merged
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this issue Oct 25, 2022
@yoshi-automation @codyoss @kimihrr
chore(all): auto-regenerate gapics (googleapis#6914)
cdf53ff 
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#927

Changes:

feat(dialogflow): Can directly set Cloud Speech model on the SpeechToTextConfig
  PiperOrigin-RevId: 482665674
  Source-Link: googleapis/googleapis@64926d5

docs(dialogflow/cx): Clarified TTL as time-to-live docs: Removed pre-GA disclaimer from Interaction Logging (has been GA for awhile)
  PiperOrigin-RevId: 482618841
  Source-Link: googleapis/googleapis@62443cf

feat(compute): Update Compute Engine API to revision 20221011 (googleapis#736)

  Source-Link: googleapis/googleapis@cb8c914

feat(pubsub): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013889
  Source-Link: googleapis/googleapis@5f68158

feat(kms): Provide easier access to IAM via the standard IAMPolicy client class
  PiperOrigin-RevId: 482013711
  Source-Link: googleapis/googleapis@6d38b26

Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@release-please release-please bot mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakyll rakyll

Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rakyll @JustinBeckwith @anthmgoogle @jba