chore(storage): fix checksum for grpc simple write #7195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In googleapis#7193 I moved the checksum logic to send on the request that initiates the upload, but I inadvertently removed sending the checksum for one-shot uploads. This PR restores the checksum logic for simple uploads. Fixes googleapis#7194
product-auto-label
bot
added
size: m
codyoss
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7193 I moved the checksum logic to send on the request that initiates the upload, but I inadvertently removed sending the checksum for one-shot uploads. This PR restores the checksum logic for simple uploads.
Fixes #7194