Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rewrite signatures for final library migration #7127

Merged
merged 3 commits into from Dec 2, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 2, 2022

Changes:

feat(spanner): rewrite signatures and type in terms of new location

feat(bigquery): rewrite signatures and type in terms of new location

feat(pubsub): rewrite signatures and type in terms of new location

feat(firestore): rewrite signatures and type in terms of new location

feat(errorreporting): rewrite signatures and type in terms of new location

feat(aiplatform): rewrite signatures and type in terms of new location

feat(logging): rewrite signatures and type in terms of new location

feat(datastore): rewrite signatures and type in terms of new location

feat(compute): rewrite signatures and type in terms of new location

feat(pubsublite): rewrite signatures and type in terms of new location

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 2, 2022
@codyoss codyoss marked this pull request as ready for review December 2, 2022 21:19
@codyoss codyoss requested review from a team, shollyman and telpirion as code owners December 2, 2022 21:19
@codyoss codyoss requested a review from a team December 2, 2022 21:19
@codyoss codyoss requested a review from a team as a code owner December 2, 2022 21:19
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on a sampling of files and scan of file paths.

@codyoss codyoss merged commit 620e6d8 into googleapis:main Dec 2, 2022
@codyoss codyoss deleted the last-batch branch December 2, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants