Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add default partition expiration to Dataset #7096

Merged

Conversation

alvarowolfx
Copy link
Contributor

Resolves #7021

@alvarowolfx alvarowolfx requested a review from a team November 23, 2022 22:28
@alvarowolfx alvarowolfx requested a review from a team as a code owner November 23, 2022 22:28
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Nov 23, 2022
@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Nov 25, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 25, 2022
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

bigquery/dataset.go Outdated Show resolved Hide resolved
@alvarowolfx alvarowolfx added the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 601c77a into googleapis:main Nov 29, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: Add defaultPartitionExpirationMs to dataset metadata
3 participants