feat(iam): start generating and refresh some libraries #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codyoss
commented
Nov 21, 2022
codyoss
commented
- Refresh the admin/apiv1 library. Keeping it out of auto generation due to conflicts in handcrafted files living alongside the client.
- Start generating a gapic for apiv1
- Start generating stubs dirs for both
- Refresh the admin/apiv1 library. Keeping it out of auto generation due to conflicts in handcrafted files living alongside the client. - Start generating a gapic for apiv1 - Start generating stubs dirs for both
product-auto-label
bot
added
size: xl
codyoss
changed the title
quartzmo
approved these changes
Nov 21, 2022
|
Breaking changes here are unfortunate. I think because of this we will not be updating the admin client for now. It appears that client was generated with a version of the generator that did not have proper iterators yet. Eventually we should do a breaking changes for IAM and get these updated as current code is not maintainable/updatable with current tooling. cc @noahdietz |
Ack. Makes sense. That's a bummer |
codyoss
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.