Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(httpreplay): specify localhost for proxy listener #7088

Merged
merged 1 commit into from Nov 22, 2022

Conversation

quartzmo
Copy link
Member

closes: #7087

@codyoss Is httpreplay ever used remotely? Will this change cause issues for anyone?

(Note that the package docs for httpreplay state: "This package is EXPERIMENTAL and is subject to change or removal without notice.")

@quartzmo quartzmo requested a review from a team as a code owner November 21, 2022 18:54
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 21, 2022
@codyoss
Copy link
Member

codyoss commented Nov 21, 2022

@quartzmo I am not sure. We just use this package as a test utility. The default of listening on all unicast IPs seems fine imo -- but not an expert in this space. I think the user report can also be solved by playing with firewall perms on their machine perhaps as well if my translation was accurate. If you are feeling pretty confident that this will not break anything I am fine moving forward, or else I would say either just leave it. Thoughts?

@quartzmo
Copy link
Member Author

If you are feeling pretty confident that this will not break anything I am fine moving forward, or else I would say either just leave it.

It doesn't break anything when used locally (meaning, when the httpreplay client and listener are running on the same host), which is my impression of how the tool is supposed to be used. I would like to go forward with this change for the benefit (at least) of the #7087 poster. On the slight chance that breakage is reported for a use case we are not aware of, then I think we can change it back again. As stated: "EXPERIMENTAL and is subject to change or removal without notice."

@quartzmo quartzmo merged commit d96cb02 into googleapis:main Nov 22, 2022
@quartzmo quartzmo deleted the httpreplay-localhost branch November 22, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpreplay: enable to specify proxy listen address
2 participants