Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bigtable): More updates for table protection #7039

Merged
merged 7 commits into from Nov 15, 2022
Merged

chore(bigtable): More updates for table protection #7039

merged 7 commits into from Nov 15, 2022

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Nov 14, 2022 •
edited

This PR adds two behaviors to the Bigtable emulator:

  • Sends FAILED_PRECONDITION error on attempt to modify a column on a protected table.
  • Verifies the contents of an UpdateTableRequest.UpdateMask with table

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the Bigtable API. labels Nov 14, 2022
@telpirion telpirion marked this pull request as ready for review November 15, 2022 21:59
@telpirion telpirion merged commit 2a42c17 into main Nov 15, 2022
@telpirion telpirion deleted the bigtable-inmem branch November 15, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2 igorbernstein2 is a code owner

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@telpirion @quartzmo