Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): enable REGAPIC and REST numeric enums #6999

Merged
merged 8 commits into from Dec 8, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Nov 7, 2022

Enables REGAPIC and REST numeric enum serialization for all API clients, except for those that are known to only support one transport / not support REST numeric enum serialization.

["grpc", "rest"] is now the default set of transports generated for a package. REST numeric enum serialization is enabled by default. As such, this removes all explicit Transports instances that match the new default.

Note: There are three beta-level packages that will take breaking changes in a follow-up PR that remove REST support.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 7, 2022
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for simplifying the config! 🎉

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Dec 6, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Dec 6, 2022
@noahdietz
Copy link
Contributor Author

I regenerated everything, pushed it to this PR, and kokoro was appeased. There was an issue with vet.sh which was my lack of gofmt prior to pushing. I've since reverted the generated changes to allow our job to do it.

@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@noahdietz noahdietz marked this pull request as ready for review December 7, 2022 23:42
@noahdietz noahdietz requested a review from a team as a code owner December 7, 2022 23:42
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Dec 8, 2022
@noahdietz noahdietz removed the stale: old Pull request is old and needs attention. label Dec 8, 2022
@noahdietz
Copy link
Contributor Author

noahdietz commented Dec 8, 2022

Similarly, I saw in a #7148 apidiff run on all affected packages we should not have any breaking changes in the next regen using this new config. There will be some follow up PRs to break a few clients that must be broken per the findings of #7148 .

@noahdietz noahdietz merged commit 28f3572 into googleapis:main Dec 8, 2022
@noahdietz noahdietz deleted the regapic-enablement branch December 8, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants