Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner/spansql): add support for interval arg of some date/timestamp functions #6950

Merged
merged 4 commits into from Nov 3, 2022

Conversation

toga4
Copy link
Contributor

@toga4 toga4 commented Oct 27, 2022

This PR adds support for interval argument of DATE_ADD, DATE_SUB, TIMESTAMP_ADD, TIMESTAMP_SUB.

Fixes: #6949

@toga4 toga4 requested review from a team as code owners October 27, 2022 14:25
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Oct 27, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2022
@rahul2393 rahul2393 added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2022
@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 3, 2022
@rahul2393
Copy link
Contributor

@toga4 cla/google is failing, please fix

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 3, 2022
@toga4
Copy link
Contributor Author

toga4 commented Nov 3, 2022

@rahul2393 now fixed.

@rahul2393 rahul2393 merged commit 1ce0f7d into googleapis:main Nov 3, 2022
@toga4 toga4 deleted the interval branch November 3, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner/spansql: generated column with interval can't be parsed
3 participants