Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigtable): update bttest for table deletion #6913

Merged
merged 5 commits into from Oct 24, 2022

Conversation

telpirion
Copy link
Contributor

This PR should help to unblock #6813

Fixes #6905

@telpirion telpirion requested review from igorbernstein2 and a team as code owners October 24, 2022 18:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the Bigtable API. labels Oct 24, 2022
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small Go nit.

bigtable/bttest/inmem.go Outdated Show resolved Hide resolved
@telpirion telpirion requested a review from enocom October 24, 2022 18:40
@googleapis googleapis deleted a comment from kevinsi4508 Oct 24, 2022
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
@telpirion telpirion enabled auto-merge (squash) October 24, 2022 20:35
@telpirion telpirion merged commit 014ed42 into main Oct 24, 2022
@telpirion telpirion deleted the bigtable-bttest-table-deletion branch October 24, 2022 20:45
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2022
kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this pull request Oct 25, 2022
* chore(bigtable): update bttest for table deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigtable: add deletion protection support in the Bigtable emulator
4 participants