chore(ci): move vet to GitHub Action #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Oct 24, 2022
product-auto-label
bot
added
size: s
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
kimihrr
pushed a commit
to kimihrr/google-cloud-go-kimia
that referenced
this pull request
Oct 25, 2022
* chore(ci): move vet to GitHub Action * vet on main * dedupe vet.sh Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the existing
vet.shscript and execution (presubmit and continuous) to GitHub Actions (execute on Pull Requests and Pushes onmain).Note: The GitHub Action dictates which version of Go the script is executed with. Currently it is our "latest" which is Go
1.19. I removed the Go version guard invet.shsince it will only ever be executed on the version we dictate, rather than both earliest a& latest like with Kokoro.I think that we should consider executing
vetonly on changed directories instead of the entire repository, similar to howapidiffworks. That is an improvement we can make later though. This is just a start.Fixes #6135