New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSub: documentation typo for subscription retry policy #6903

Closed

minsung-moloco opened this issue Oct 20, 2022 · 1 comment · Fixed by #6909

Assignees

Labels

minsung-moloco commented Oct 20, 2022

PubSub documentation states subscription retry policy's maximum backoff defaults to 600 seconds while go-client documentation states 10 seconds. I assume this is a typo in the go-client source code side.

product-auto-label bot added the api: pubsub label

blunderbuss-gcf bot assigned hongalex

hongalex mentioned this issue

docs(pubsub): update subscription retry policy defaults #6909

Merged

gcf-merge-on-green bot closed this as completed in #6909

gcf-merge-on-green bot pushed a commit that referenced this issue


          docs(pubsub): update subscription retry policy defaults (#6909)

c5c2f8f

Fixes #6903

release-please bot mentioned this issue

chore(main): release pubsub 1.26.0 #6667

Merged

Member

hongalex commented Oct 24, 2022 •

edited

Thanks for filing an issue!

gcf-merge-on-green bot pushed a commit that referenced this issue


          chore(main): release pubsub 1.26.0 (#6667)

afbecb6

🤖 I have created a release *beep* *boop*
---


## [1.26.0](https://togithub.com/googleapis/google-cloud-go/compare/pubsub/v1.25.1...pubsub/v1.26.0) (2022-10-24)


### Features

* **pubsub:** Add support for snapshot labels ([#6835](https://togithub.com/googleapis/google-cloud-go/issues/6835)) ([c17851b](https://togithub.com/googleapis/google-cloud-go/commit/c17851b5c3d811cd3e6a28162f0e399bb31a1363))


### Bug Fixes

* **pubsub:** Remove unused AckResult map ([#6656](https://togithub.com/googleapis/google-cloud-go/issues/6656)) ([5f69002](https://togithub.com/googleapis/google-cloud-go/commit/5f690022551ac584e5c66af4324a17d7044a898d))


### Documentation

* **pubsub:** Fix comments on message for exactly once delivery ([#6878](https://togithub.com/googleapis/google-cloud-go/issues/6878)) ([a8109e2](https://togithub.com/googleapis/google-cloud-go/commit/a8109e2d3257d1698ce1b751618428ef25cbb859)), refs [#6877](https://togithub.com/googleapis/google-cloud-go/issues/6877)
* **pubsub:** Update streams section ([#6682](https://togithub.com/googleapis/google-cloud-go/issues/6682)) ([7b4e2b4](https://togithub.com/googleapis/google-cloud-go/commit/7b4e2b412058f965a9f9159231afe551a6f58a74))
* **pubsub:** Update subscription retry policy defaults ([#6909](https://togithub.com/googleapis/google-cloud-go/issues/6909)) ([c5c2f8f](https://togithub.com/googleapis/google-cloud-go/commit/c5c2f8f7125034c611edf1d08ca35ece6554c454)), refs [#6903](https://togithub.com/googleapis/google-cloud-go/issues/6903)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this issue


          docs(pubsub): update subscription retry policy defaults (googleapis#6909

)

Fixes googleapis#6903

kimihrr pushed a commit to kimihrr/google-cloud-go-kimia that referenced this issue


          chore(main): release pubsub 1.26.0 (googleapis#6667)

5e45b1e

🤖 I have created a release *beep* *boop*
---


## [1.26.0](https://togithub.com/googleapis/google-cloud-go/compare/pubsub/v1.25.1...pubsub/v1.26.0) (2022-10-24)


### Features

* **pubsub:** Add support for snapshot labels ([googleapis#6835](https://togithub.com/googleapis/google-cloud-go/issues/6835)) ([c17851b](https://togithub.com/googleapis/google-cloud-go/commit/c17851b5c3d811cd3e6a28162f0e399bb31a1363))


### Bug Fixes

* **pubsub:** Remove unused AckResult map ([googleapis#6656](https://togithub.com/googleapis/google-cloud-go/issues/6656)) ([5f69002](https://togithub.com/googleapis/google-cloud-go/commit/5f690022551ac584e5c66af4324a17d7044a898d))


### Documentation

* **pubsub:** Fix comments on message for exactly once delivery ([googleapis#6878](https://togithub.com/googleapis/google-cloud-go/issues/6878)) ([a8109e2](https://togithub.com/googleapis/google-cloud-go/commit/a8109e2d3257d1698ce1b751618428ef25cbb859)), refs [googleapis#6877](https://togithub.com/googleapis/google-cloud-go/issues/6877)
* **pubsub:** Update streams section ([googleapis#6682](https://togithub.com/googleapis/google-cloud-go/issues/6682)) ([7b4e2b4](https://togithub.com/googleapis/google-cloud-go/commit/7b4e2b412058f965a9f9159231afe551a6f58a74))
* **pubsub:** Update subscription retry policy defaults ([googleapis#6909](https://togithub.com/googleapis/google-cloud-go/issues/6909)) ([c5c2f8f](https://togithub.com/googleapis/google-cloud-go/commit/c5c2f8f7125034c611edf1d08ca35ece6554c454)), refs [googleapis#6903](https://togithub.com/googleapis/google-cloud-go/issues/6903)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment