Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): move apidiff to GitHub Action #6901

Merged
merged 12 commits into from Oct 20, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Oct 19, 2022

This moves the apidiff checks to GitHub Actions, based on the success we've had with the same thing in go-genproto.

It also removes the apidiff check from the kokoro presubmit.

Updates #6135.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 19, 2022
@noahdietz noahdietz force-pushed the apidiff-action branch 2 times, most recently from 2e4501b to 6730e07 Compare October 19, 2022 23:22
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 19, 2022
@noahdietz noahdietz marked this pull request as ready for review October 20, 2022 00:05
@noahdietz noahdietz requested a review from a team as a code owner October 20, 2022 00:05
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@noahdietz noahdietz merged commit aacddfd into googleapis:main Oct 20, 2022
@noahdietz noahdietz deleted the apidiff-action branch October 20, 2022 16:25
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants