Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): replace deprecated usage of ioutil in sample code #6872

Merged
merged 2 commits into from Oct 19, 2022

Conversation

sfc-gh-kleonhard
Copy link
Contributor

No description provided.

@sfc-gh-kleonhard sfc-gh-kleonhard requested review from a team as code owners October 14, 2022 20:27
@google-cla
Copy link

google-cla bot commented Oct 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. samples Issues that are directly related to samples. labels Oct 14, 2022
@quartzmo quartzmo changed the title Replace deprecated usage of ioutil in sample code docs(storage): replace deprecated usage of ioutil in sample code Oct 14, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 14, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@quartzmo quartzmo added the api: storage Issues related to the Cloud Storage API. label Oct 14, 2022
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

There are a bunch of other uses of ioutil elsewhere in this package, but we can clean them up separately.

To merge this PR, we'll need you to sign the CLA; there is a link below.

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@sfc-gh-kleonhard
Copy link
Contributor Author

Thanks for your contribution!

There are a bunch of other uses of ioutil elsewhere in this package, but we can clean them up separately.

To merge this PR, we'll need you to sign the CLA; there is a link below.

Thanks Chris, got the CLA taken care of.

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 19, 2022
@tritone tritone merged commit d14ee26 into googleapis:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants