chore(storage): enable more grpc integration tests #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
noahdietz
approved these changes
Oct 12, 2022
tritone
approved these changes
Oct 13, 2022
|
|
||
| bkt := client.Bucket(bucketName) | ||
| minObjectSize := 2500000 // 2.5 Mb |
| ctx := context.Background() | ||
| clientFullControl := testConfig(ctx, t) | ||
| defer clientFullControl.Close() | ||
| multiTransportTest(context.Background(), t, func(t *testing.T, ctx context.Context, bucket, _ string, client *Client) { |
There was a problem hiding this comment.
What do we think about having multiple multiTransportTest calls in a single integration test? Maybe this should be broken up? On the other hand if it doesn't break anything, probably fine... @noahdietz
kimihrr
pushed a commit
to kimihrr/google-cloud-go-kimia
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables tests: TestIntegration_ReaderAttrs, TestIntegration_ReaderCancel, TestIntegration_Scopes
Also expands the Scopes test to test more scopes