feat(storage): add Autoclass support #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
tritone
reviewed
Oct 11, 2022
| @@ -60,6 +60,7 @@ func TestBucketAttrsToRawBucket(t *testing.T) { | |||
| Encryption: &BucketEncryption{DefaultKMSKeyName: "key"}, | |||
There was a problem hiding this comment.
Let's make sure we have test coverage for the proto converters as well. Also, you should make an integration test to cover the roundtrip with the service (both create and update).
There was a problem hiding this comment.
Yep was meaning to write an integration test... also added 2 tests for the proto converters. @tritone PTAL, thanks!
There was a problem hiding this comment.
Thanks for adding these additional tests; didn't realize we were missing these unit tests for proto converter methods. We should consider auditing and filling others in if they are missing. @noahdietz @BrennaEpp
tritone
added
the
do not merge
product-auto-label
bot
added
size: l
tritone
reviewed
Oct 13, 2022
tritone
reviewed
Oct 13, 2022
tritone
approved these changes
Oct 18, 2022
cojenco
removed
the
do not merge
This was referenced Nov 1, 2022
Closed
tritone
pushed a commit
to GoogleCloudPlatform/golang-samples
that referenced
this pull request
Nov 7, 2022
Fixes #2707 Requires googleapis/google-cloud-go#6828 Tests pass locally with library feature support
Cori1109
added a commit
to Cori1109/golang-samples
that referenced
this pull request
Jan 9, 2023
Fixes #2707 Requires googleapis/google-cloud-go#6828 Tests pass locally with library feature support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Autoclass, which allows for automatic selection of the best storage class based on object access patterns
Fixes #6592