chore(storage): enable several tests for grpc + related fixes #6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables tests: BucketPolicyOnly, ACL, PredefinedACLs Fixes: gets all fields in GetBucket and GetObject (were missing ACLs); makes sure ACL is sent when ACL is not sent but PredefinedACL is; initializes Bucket_IamConfig (was causing segfault); sends UBLA field when disabled in an update Additionally cleans up acl checking in tests to use the same method
product-auto-label
bot
added
size: l
tritone
approved these changes
Oct 11, 2022
| @@ -522,7 +521,7 @@ func (c *grpcStorageClient) UpdateObject(ctx context.Context, bucket, object str | |||
| } | |||
| // Note: This API currently does not support entites using project ID. | |||
| // Use project numbers in ACL entities. Pending b/233617896. | |||
| if uattrs.ACL != nil { | |||
| if uattrs.ACL != nil || len(uattrs.PredefinedACL) > 0 { | |||
There was a problem hiding this comment.
I'm surprised that this is necessary for PredefinedACL given how it is set in L485
There was a problem hiding this comment.
This line is to make sure the update mask contains something so we can send the request
There was a problem hiding this comment.
Gotcha; I guess this is safe because if you specify a PredefinedACL, you are overwriting the existing ACLs anyway.
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables tests: BucketPolicyOnly, ACL, PredefinedACLs
Fixes: gets all fields in GetBucket and GetObject (were missing ACLs); makes sure ACL is sent when ACL is not sent but PredefinedACL is; initializes Bucket_IamConfig (was causing segfault); sends UBLA field when disabled in an update
Additionally cleans up acl checking in tests to use the same method