Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): enable more tests for grpc #6820

Merged
merged 5 commits into from Oct 12, 2022
Merged

chore(storage): enable more tests for grpc #6820

merged 5 commits into from Oct 12, 2022

Conversation

noahdietz
Copy link
Contributor

Enables multi-transport tests for the following tests:

  • TestIntegration_ValidObjectNames
  • TestIntegration_ZeroSizedObject
  • TestIntegration_BucketIAM
  • TestIntegration_CancelWrite

@noahdietz noahdietz requested a review from tritone October 6, 2022 22:08
@noahdietz noahdietz requested review from a team as code owners October 6, 2022 22:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 6, 2022
@noahdietz noahdietz added automerge Merge the pull request once unit tests and other checks pass. and removed size: m Pull request size is medium. labels Oct 6, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 6, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 10, 2022
BrennaEpp
BrennaEpp approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 84e1508 into googleapis:main Oct 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennaEpp BrennaEpp BrennaEpp approved these changes

@tritone tritone Awaiting requested review from tritone

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahdietz @BrennaEpp