Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aiplatform): start generating stubs for beta #6723

Merged
merged 3 commits into from Sep 22, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 22, 2022

No description provided.

Some apis, mainly aiplatform, have nested helper types in subdir
under the serivce proto defs. We only want to look at the files
in the service dir to generate the gapic service.
@codyoss codyoss requested a review from a team as a code owner September 22, 2022 16:16
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: aiplatform Issues related to the AI Platform API. labels Sep 22, 2022
@codyoss codyoss added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: aiplatform Issues related to the AI Platform API. size: xl Pull request size is extra large. labels Sep 22, 2022
@codyoss
Copy link
Member Author

codyoss commented Sep 22, 2022

Waiting on #6721 before merging this.

Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot.

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2022
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Sep 22, 2022
@codyoss codyoss enabled auto-merge (squash) September 22, 2022 19:12
@codyoss codyoss merged commit 71f5ab9 into googleapis:main Sep 22, 2022
@codyoss codyoss deleted the aiplat-2 branch September 22, 2022 19:13
@release-please release-please bot mentioned this pull request Sep 22, 2022
@release-please release-please bot mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants