feat(firestore): adds snapshot reads impl. #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
enocom
reviewed
Oct 3, 2022
enocom
requested changes
Oct 12, 2022
| }, | ||
| }) | ||
|
|
||
| _, err := c.WithReadOptions(ReadTime(tm)).GetAll(ctx, []*DocumentRef{ |
There was a problem hiding this comment.
Does this call fail if it doesn't match what was added with srv.addRPC above?
firestore/transaction_test.go
Outdated
| Database: db, | ||
| Transaction: tid, | ||
| }, | ||
| &pb.CommitResponse{CommitTime: aTimestamp3}, |
There was a problem hiding this comment.
Could we declare a timestamp within this test? Otherwise it's hard to know how it relates to tm.
There was a problem hiding this comment.
We could, but that wouldn't really exercise anything meaningful. The mock server simply returns the response object we define here--we would be testing that we set up the response in the mock server correctly, not the read time behavior.
enocom
requested changes
Oct 12, 2022
enocom
approved these changes
Oct 13, 2022
telpirion
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ReadOptionstruct and allows callers to specify a read time for documents from the database.