Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): adds COUNT aggregation query #6714

Merged
merged 29 commits into from Oct 26, 2022
Merged

feat(datastore): adds COUNT aggregation query #6714

merged 29 commits into from Oct 26, 2022

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Sep 20, 2022 •
edited

NOTES:

  • This PR includes a change to go.mod that points google.golang.org/genproto at a local development copy of the repro; that change needs to be reverted prior to merge.
  • This PR does not include integration tests.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the Datastore API. labels Sep 20, 2022
@enocom enocom assigned enocom and unassigned enocom Sep 29, 2022
@telpirion telpirion marked this pull request as ready for review October 17, 2022 21:51
@telpirion telpirion requested review from enocom and a team as code owners October 17, 2022 21:51
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 17, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 17, 2022
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Oct 21, 2022
@telpirion telpirion enabled auto-merge (squash) October 26, 2022 17:20
@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2022
@telpirion telpirion merged commit 27363ca into main Oct 26, 2022
@telpirion telpirion deleted the datastore-count branch October 26, 2022 18:09
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2022
@release-please release-please bot mentioned this pull request Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@enocom enocom Awaiting requested review from enocom

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. size: l Pull request size is large. stale: old Pull request is old and needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@telpirion @quartzmo @enocom