Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rewrite beta clients #6711

Merged
merged 15 commits into from Sep 21, 2022
Merged

chore: rewrite beta clients #6711

merged 15 commits into from Sep 21, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 20, 2022

This change rewrites signature for all beta clients to be in terms of the new type definitions. This is safe because all the modules are updated to the latest genproto version which has corresponding type aliases.

Also removed a secretmanager beta client that was not mapping to the correct protos.

Changes:

feat(binaryauthorization): rewrite signatures in terms of new types for betas

feat(oslogin): rewrite signatures in terms of new types for betas

feat(retail): rewrite signatures in terms of new types for betas

feat(dataform): rewrite signatures in terms of new types for betas

feat(datalabeling): rewrite signatures in terms of new types for betas

feat(documentai): rewrite signatures in terms of new types for betas

feat(memcache): rewrite signatures in terms of new types for betas

feat(metastore): rewrite signatures in terms of new types for betas

feat(notebooks): rewrite signatures in terms of new types for betas

feat(phishingprotection): rewrite signatures in terms of new types for betas

feat(recommendationengine): rewrite signatures in terms of new types for betas

feat(securitycenter): rewrite signatures in terms of new types for betas

feat(servicedirectory): rewrite signatures in terms of new types for betas

feat(webrisk): rewrite signatures in terms of new types for betas

feat(dataqna): rewrite signatures in terms of new types for betas

feat(functions): rewrite signatures in terms of new types for betas

feat(lifesciences): rewrite signatures in terms of new types for betas

feat(mediatranslation): rewrite signatures in terms of new types for betas

feat(osconfig): rewrite signatures in terms of new types for betas

feat(security): rewrite signatures in terms of new types for betas

feat(vision): rewrite signatures in terms of new types for betas

feat(artifactregistry): rewrite signatures in terms of new types for betas

feat(automl): rewrite signatures in terms of new types for betas

feat(gkeconnect): rewrite signatures in terms of new types for betas

feat(networkconnectivity): rewrite signatures in terms of new types for betas

feat(redis): rewrite signatures in terms of new types for betas

feat(talent): rewrite signatures in terms of new types for betas

feat(videointelligence): rewrite signatures in terms of new types for betas

feat(assuredworkloads): rewrite signatures in terms of new types for betas

feat(billing): rewrite signatures in terms of new types for betas

feat(dialogflow): rewrite signatures in terms of new types for betas

feat(recaptchaenterprise): rewrite signatures in terms of new types for betas

feat(recommender): rewrite signatures in terms of new types for betas

feat(scheduler): rewrite signatures in terms of new types for betas

feat(cloudtasks): rewrite signatures in terms of new types for betas

feat(workflows): rewrite signatures in terms of new types for betas

feat(analytics): rewrite signatures in terms of new types for betas

feat(area120): rewrite signatures in terms of new types for betas

feat(datacatalog): rewrite signatures in terms of new types for betas

feat(datastream): rewrite signatures in terms of new types for betas

feat(domains): rewrite signatures in terms of new types for betas

feat(gaming): rewrite signatures in terms of new types for betas

feat(gkehub): rewrite signatures in terms of new types for betas

feat(networksecurity): rewrite signatures in terms of new types for betas

feat(speech): rewrite signatures in terms of new types for betas

feat(dataflow): rewrite signatures in terms of new types for betas

feat(language): rewrite signatures in terms of new types for betas

feat(privatecatalog): rewrite signatures in terms of new types for betas

feat(secretmanager): remove beta client that no longer has source protos

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 20, 2022
@codyoss codyoss changed the title Betas part2 chore: rewrite beta clients Sep 20, 2022
This has been pointing at the wrong protos for many years. Lets
remove the client
@snippet-bot
Copy link

snippet-bot bot commented Sep 20, 2022

Here is the summary of changes.

You are about to delete 15 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Sep 20, 2022
@codyoss codyoss marked this pull request as ready for review September 20, 2022 21:02
@codyoss codyoss requested a review from a team September 20, 2022 21:02
@codyoss codyoss requested a review from a team as a code owner September 20, 2022 21:02
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@codyoss codyoss enabled auto-merge (squash) September 21, 2022 19:21
@codyoss codyoss merged commit 9f303f9 into googleapis:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants