Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): destroy session when client is closing #6700

Merged
merged 4 commits into from Sep 21, 2022
Merged

Conversation

rahul2393
Copy link
Contributor

Fixes: #6590

@rahul2393 rahul2393 requested review from a team as code owners September 20, 2022 14:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the Spanner API. labels Sep 20, 2022
@rahul2393 rahul2393 changed the title fix(spanner): destroy session when client is closing. fix(spanner): destroy session when client is closing Sep 20, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 20, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@rahul2393 rahul2393 merged commit a1ce541 into main Sep 21, 2022
@rahul2393 rahul2393 deleted the fix-deadlock-case branch September 21, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: Deadlock if iterator.Stop() is called after client.Close()
3 participants