Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): multi-transport BucketCreateDelete test #6670

Merged

Conversation

noahdietz
Copy link
Contributor

Refactor TestIntegration_BucketCreateDelete to execute on both transports.

Fix nil pointer access in gRPC transport.

Skip gRPC transport for this test until bug in service is fixed.

@noahdietz noahdietz requested review from a team as code owners September 14, 2022 20:28
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the Cloud Storage API. labels Sep 14, 2022
Bucket: b,
BucketId: b.GetName(),
}
if attrs != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, nice catch.

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 37d209c into googleapis:main Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@noahdietz noahdietz deleted the test-bucket-create-delete branch September 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants