Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): use context value to skip transport tests #6662

Merged
merged 3 commits into from Sep 13, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Sep 13, 2022

Introduce the skipTransportTestKey context.Value key in order to skip specific integration tests for one of the two supported transports. The test uses one of the two helpers to create the proper context, either skipGRPC or skipHTTP, combined with the reason for skipping as the value, and the test runner will skip that transport if it is present in the context supplied to it, logging the reason with the Skip.

Refactor and skip two tests, BucketLifecycle which is broken for gRPC atm, and MultiMessageWriteGRPC which is just meant to exercise edge cases in the gRPC Writer implementation.

@noahdietz noahdietz requested review from a team as code owners September 13, 2022 21:24
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Sep 13, 2022
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Noah!

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d99ce46 into googleapis:main Sep 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants