chore(storage): use context value to skip transport tests #6662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
skipTransportTestKey
context.Value
key in order to skip specific integration tests for one of the two supported transports. The test uses one of the two helpers to create the proper context, eitherskipGRPC
orskipHTTP
, combined with the reason for skipping as the value, and the test runner will skip that transport if it is present in the context supplied to it, logging the reason with the Skip.Refactor and skip two tests, BucketLifecycle which is broken for gRPC atm, and MultiMessageWriteGRPC which is just meant to exercise edge cases in the gRPC Writer implementation.