fix(bigquery): parse timestamp query parameter with RFC3339 #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
shollyman
approved these changes
Sep 12, 2022
| @@ -416,7 +416,15 @@ func convertParamValue(qval *bq.QueryParameterValue, qtype *bq.QueryParameterTyp | |||
| if isNullScalar(qval) { | |||
| return NullTimestamp{Valid: false}, nil | |||
| } | |||
| return time.Parse(timestampFormat, qval.Value) | |||
| t, err := time.Parse(timestampFormat, qval.Value) | |||
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps on BigQuery have a format similar to RFC3339.
When creating a Query Job via the API, users can pass a timestamp with string
2020-10-15T00:00:00Z, which is a valid parameter. But if a given Job was created with aTIMESTAMPfollowing that format and is read back using this library, it fails (as reported on #6651 ) because we expectTIMESTAMPSto have only this format:"2006-01-02 15:04:05.999999-07:00"This PR also tries to parse
TIMESTAMPSusing GoRFC3339Nano, similarly on how thecivil.ParseDateTimefunction tries multiple formats.Resolves #6651