Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): define append retry predicate #6650

Merged
merged 9 commits into from Sep 16, 2022

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Sep 9, 2022

This PR augments the existing retry predicate used for evaluating reconnection, and also enables it to be used for evaluating whether appends can be retried. A future PR will plumb in append retry logic.

Towards internal b/245963141

This PR models the retry predicate we'll use for evaluating whether
appends should be retried automatically.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the BigQuery API. labels Sep 9, 2022
bigquery/storage/managedwriter/retry.go Outdated Show resolved Hide resolved
bigquery/storage/managedwriter/retry.go Outdated Show resolved Hide resolved
bigquery/storage/managedwriter/retry.go Outdated Show resolved Hide resolved
@shollyman shollyman marked this pull request as ready for review September 15, 2022 19:49
@shollyman shollyman requested a review from a team September 15, 2022 19:49
@shollyman shollyman requested a review from a team as a code owner September 15, 2022 19:49
@shollyman shollyman requested review from prash-mi, yirutang and alvarowolfx and removed request for prash-mi September 15, 2022 19:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Sep 16, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 16, 2022
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman enabled auto-merge (squash) September 16, 2022 21:51
@shollyman shollyman merged commit 478b8dd into googleapis:main Sep 16, 2022
@shollyman shollyman deleted the append-retries-2 branch September 16, 2022 22:10
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 21, 2022
🤖 I have created a release *beep* *boop*
---


## [1.42.0](bigquery/v1.41.0...bigquery/v1.42.0) (2022-09-21)


### Features

* **bigquery/analyticshub:** Start generating apiv1 ([#6707](#6707)) ([feb7d7d](feb7d7d))
* **bigquery/datapolicies:** Start generating apiv1beta1 ([#6697](#6697)) ([f5443e8](f5443e8))
* **bigquery/reservation/apiv1beta1:** add REST transport ([f7b0822](f7b0822))
* **bigquery/storage/managedwriter:** Define append retry predicate ([#6650](#6650)) ([478b8dd](478b8dd))
* **bigquery/storage:** add proto annotation for non-ascii field mapping ([ec1a190](ec1a190))
* **bigquery:** Add reference file schema option for federated formats ([#6693](#6693)) ([3d26091](3d26091))
* **bigquery:** Add support for explicit query parameter type ([#6596](#6596)) ([d59b5b2](d59b5b2)), refs [#4704](#4704)


### Bug Fixes

* **bigquery/connection:** integrate  gapic-generator-python-1.4.1 and enable more py_test targets ([ec1a190](ec1a190))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants