Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/aliasfix): properly truncate and backup files #6637

Merged
merged 1 commit into from Sep 8, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 8, 2022

  • Use os.Create to truncate existing file if needed
  • Use named imports to capture error
  • Create a bak incase anything goes wrong. We don't want to delete peoples code :)
  • Bubble up error if any from WalkDir

- Use os.Create to truncate existing file if needed
- Use named imports to capture error
- Create a bak incase anything goes wrong. We don't want to delete
  peoples code :)
@codyoss codyoss requested a review from a team as a code owner September 8, 2022 20:54
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 8, 2022
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good idea on the bak

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022
@codyoss codyoss merged commit 60e120c into googleapis:main Sep 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022
@codyoss codyoss deleted the aliasfix-trunc branch September 8, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants