Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(asset): rewrite signatures in terms of new types for betas #6624

Merged
merged 6 commits into from Sep 8, 2022
Merged

feat(asset): rewrite signatures in terms of new types for betas #6624

merged 6 commits into from Sep 8, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Sep 7, 2022

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: cloudasset Issues related to the Cloud Asset Inventory API. labels Sep 7, 2022
@codyoss codyoss mentioned this pull request Sep 7, 2022
Merged
@codyoss codyoss marked this pull request as ready for review September 7, 2022 19:20
@codyoss codyoss requested a review from a team as a code owner September 7, 2022 19:20
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2022
@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2022
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022
quartzmo
quartzmo approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of what might not be covered in these changes that should be; but everything here LGTM.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 1ad1aba into googleapis:main Sep 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022
@release-please release-please bot mentioned this pull request Sep 8, 2022
Merged
@codyoss codyoss deleted the mig-asset-part1 branch September 8, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codyoss @quartzmo