Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): add scenario 8 to retry conformance tests #6556

Merged
merged 13 commits into from Sep 13, 2022
Merged

test(storage): add scenario 8 to retry conformance tests #6556

merged 13 commits into from Sep 13, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Aug 23, 2022 •
edited

This adds scenario 8 to test downloads can handle complex retries, per internal docs go/retry-conf-test-media-ops

  • add data integrity checks for downloads in retry conf tests
  • introduce new field method.Group to test proto
  • update test schema
  • construct 9MiB larger test files to enable S8

Update: testbench new tag released on 08/29 with googleapis/storage-testbench#397

Testcase as the following

  1. client makes a request
  2. request returns with 2xx
  3. client starts reading the request body
  4. the body stream is broken a few bytes into reading

Note: comma in the license headers had to be removed per the newly enabled header-checker-lint

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Aug 23, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022
@cojenco cojenco marked this pull request as ready for review August 31, 2022 21:55
@cojenco cojenco requested review from a team as code owners August 31, 2022 21:55
@cojenco cojenco requested a review from tritone September 7, 2022 23:06
tritone
tritone reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, one suggestion about how this should be factored

storage/retry_conformance_test.go Show resolved Hide resolved
storage/retry_conformance_test.go Outdated Show resolved Hide resolved
@cojenco cojenco merged commit 74b6ad4 into googleapis:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cojenco @tritone @kokoro-team