Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: undefined: pubsub.AckResult when updating Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 #6555

Closed
chrisntb opened this issue Aug 23, 2022 · 4 comments · Fixed by #6558
Closed

pubsub: undefined: pubsub.AckResult when updating Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 #6555

chrisntb opened this issue Aug 23, 2022 · 4 comments · Fixed by #6558
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chrisntb
Copy link

This morning when we update our dependencies using command go get -u all; go mod tidy && go mod vendor v1.25.0 of cloud.google.com/go/pubsub is pulled down and this causes our build to fail with these errors:

vendor/cloud.google.com/go/pubsub/message.go:109:26: undefined: pubsub.AckResult
vendor/cloud.google.com/go/pubsub/message.go:112:34: undefined: pubsub.AcknowledgeStatus
vendor/cloud.google.com/go/pubsub/iterator.go:553:13: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:594:14: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:760:14: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:762:14: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:772:13: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:774:13: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:776:13: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:781:12: undefined: pubsub.SetAckResult
vendor/cloud.google.com/go/pubsub/iterator.go:781:12: too many errors
@chrisntb chrisntb changed the title undefined: pubsub.AckResult when updateing Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 undefined: pubsub.AckResult when updating Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 Aug 23, 2022
@gnagel
Copy link

gnagel commented Aug 23, 2022

Same here 🤞

@Tigraine
Copy link

Same here ☝️

@codyoss codyoss added the api: pubsub Issues related to the Pub/Sub API. label Aug 24, 2022
@codyoss codyoss added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Aug 24, 2022
@codyoss codyoss changed the title undefined: pubsub.AckResult when updating Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 pubsub: undefined: pubsub.AckResult when updating Go version cloud.google.com/go/pubsub v1.24.0 => v1.25.0 Aug 24, 2022
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Aug 24, 2022
@codyoss
fix(pubsub): up version of cloud.google.com/go
65b95ea 
In googleapis#6506 changes to internal were made that are not apart of the
pubsub module. The pubsub module was releated before the internal
changes were released resulting in build errors for those that
pulled the latest pubsub version.

Fixes: googleapis#6555
@codyoss codyoss mentioned this issue Aug 24, 2022
Merged
@codyoss
Copy link
Member

codyoss commented Aug 24, 2022

Thanks for the report and sorry for the inconvenience. A release should be out today to fix these error but in the meantime please downgrade the pubsub module back to 1.24.0 or upgrade cloud.googe.com/go to v0.104.0

gcf-merge-on-green bot pushed a commit that referenced this issue Aug 24, 2022
@codyoss
fix(pubsub): up version of cloud.google.com/go (#6558)
be9dcfb 
In #6506 changes to internal were made that are not apart of the
pubsub module. The pubsub module was released before the internal
changes were released resulting in build errors for those that
pulled the latest pubsub version.

Fixes: #6555
@release-please release-please bot mentioned this issue Aug 24, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 24, 2022
@release-please
chore(main): release pubsub 1.25.1 (#6559)
75065bc 
🤖 I have created a release *beep* *boop*
---


## [1.25.1](pubsub/v1.25.0...pubsub/v1.25.1) (2022-08-24)


### Bug Fixes

* **pubsub:** up version of cloud.google.com/go ([#6558](#6558)) ([be9dcfb](be9dcfb)), refs [#6555](#6555)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@codyoss
Copy link
Member

codyoss commented Aug 24, 2022

Running go get cloud.google.com/go/pubusb@1.25.1 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pubsub): up version of cloud.google.com/go codyoss/google-cloud-go
5 participants
@Tigraine @gnagel @codyoss @hongalex @chrisntb